Use file names for hash keys instead of the song ID.#1
Open
sanjoy wants to merge 1 commit intopft:masterfrom
sanjoy:mpd-restart-bugfix
Open
Use file names for hash keys instead of the song ID.#1sanjoy wants to merge 1 commit intopft:masterfrom sanjoy:mpd-restart-bugfix
sanjoy wants to merge 1 commit intopft:masterfrom
sanjoy:mpd-restart-bugfix
Conversation
MPD resets the ID counter when restarted, causing mingus to display bogus tracks after a restart. This patch works around the issue by hashing on the songs' file names.
|
Not sure what the implications of these changes would be for those (like me) using a streaming back-end for MPD, like Mopidy, would be. I don't know if Mopidy actually ends up writing files that represent the data being streamed, or not. Anyway, just something to keep in mind. Though "sanjoy commented on Sep 22, 2011"... I'm sure there's no danger of it being merged any time soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPD resets the ID counter when restarted, causing mingus to display
bogus tracks after a restart. This patch works around the issue by
hashing on the songs' file names.